StephanEwen commented on a change in pull request #14175:
URL: https://github.com/apache/flink/pull/14175#discussion_r532205583
##########
File path: docs/ops/state/savepoints.md
##########
@@ -110,13 +110,8 @@ For example with a `FsStateBackend` or
`RocksDBStateBackend`:
/savepoints/savepoint-:shortjobid-:savepointid/...
{% endhighlight %}
-<div class="alert alert-info">
- <strong>Note:</strong>
-Although it looks as if the savepoints may be moved, it is currently not
possible due to absolute paths in the <code>_metadata</code> file.
-Please follow <a
href="https://issues.apache.org/jira/browse/FLINK-5778";>FLINK-5778</a> for
progress on lifting this restriction.
-</div>
-
-Note that if you use the `MemoryStateBackend`, metadata *and* savepoint state
will be stored in the `_metadata` file. Since it is self-contained, you may
move the file and restore from any location.
+Note that if you use the `MemoryStateBackend`, metadata *and* savepoint state
will be stored in the `_metadata` file.
Review comment:
What do you think about changing this to:
```
Savepoints can generally be moved by moving (or copying) the entire
savepoint directory to a different location, and Flink will be able to restore
from the moved savepoint.
<div class="alert alert-warning">An exception to that is if *entropy
injection* is activated: In that case the savepoint directory will not contain
all savepoint data files, because the injected path entropy spreads the files
over many directories. Lacking a common savepoint root directory, the
savepoints will contain absolute path references, which prevent moving the
directory.</div>
<div class="alert alert-warning">Unlike savepoints, checkpoints cannot
generally be moved to a different location, because checkpoints may include
some absolute path references.</div>
If you use the `MemoryStateBackend`, metadata *and* savepoint state will be
stored in the `_metadata` file, so don't be confused by the absence of
additional data files.
```
I would drop the reference to a closed JIRA issue here, users should not
feel like they need to look into the bug tracker to understand a feature.
##########
File path: docs/ops/state/savepoints.md
##########
@@ -94,7 +94,7 @@ When triggering a savepoint, a new savepoint directory is
created where the data
<strong>Attention:</strong> The target directory has to be a location
accessible by both the JobManager(s) and TaskManager(s) e.g. a location on a
distributed file-system.
Review comment:
Can we change this to "...location on a distributed file-system or
Object Store." ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
