aljoscha commented on a change in pull request #14157:
URL: https://github.com/apache/flink/pull/14157#discussion_r532492542
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientFactory.java
##########
@@ -62,4 +62,13 @@
* @return the corresponding {@link ClusterSpecification} for a new
Flink cluster
*/
ClusterSpecification getClusterSpecification(Configuration
configuration);
+
+ /**
+ * Returns the option to be used when trying to execute an application
in Application Mode
+ * using this cluster client factory, or an empty string if the
environment of this cluster client
+ * factory does not support Application Mode.
+ */
+ default String getApplicationTargetName() {
Review comment:
This could be `Optional<String>`. Even in this PR you're returning
`null` in `DummyClusterClientServiceLoader`, which could then be
`Optional.empty()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
