[ 
https://issues.apache.org/jira/browse/FLINK-20439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241388#comment-17241388
 ] 

Zhu Zhu commented on FLINK-20439:
---------------------------------

`JobMasterGateway#scheduleOrUpdateConsumers()` makes it possible to trigger 
scheduling when a task has produced data to PIPELINED result, which can be 
faster than notifying until task is FINISHED. This can help for future 
development of advanced SchedulingStrategy. That's why I prefer to simply it 
instead of totally removing it. 

I think we can rename all `scheduleOrUpdateConsumers` to 
`notifyPipelinedPartitionConsumable` and JM directly notifies this event to 
SchedulerNG. SchedulerNG further then notifies this event to 
`SchedulingStrategy`. `ExecutionGraph#scheduleOrUpdateConsumers()` and 
`Execution#scheduleOrUpdateConsumers()` are not needed and can be removed. 

> Consider simplifying or removing mechanism to scheduleOrUpdateConsumers
> -----------------------------------------------------------------------
>
>                 Key: FLINK-20439
>                 URL: https://issues.apache.org/jira/browse/FLINK-20439
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Coordination
>            Reporter: Zhu Zhu
>            Priority: Major
>             Fix For: 1.13.0
>
>
> Execution#scheduleOrUpdateConsumers() was used for multiple purposes:
> - schedule a vertex when its PIPELINED inputs have produced data 
> - schedule a vertex when its BLOCKING inputs have finished
> - update consumed partition info to RUNNING consumers
> - cache consumed partition info for DEPLOYING consumers
> It is not needed anymore in the latest pipelined region scheduling because 
> - a region will be scheduled only when all its upstream regions have finished
> - a vertex will always know all its consumed partitions when scheduled
> So we can consider how to simply or remove it, which also involves things 
> like UnknownInputChannel, ResultPartitionConsumableNotifier, 
> Execution#cachePartitionInfo(), etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to