SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533853218



##########
File path: 
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientJobClientAdapter.java
##########
@@ -116,8 +115,7 @@ public JobID getJobID() {
                                                try {
                                                        return 
jobResult.toJobExecutionResult(classLoader);
                                                } catch (Throwable t) {
-                                                       throw new 
CompletionException(
-                                                                       new 
ProgramInvocationException("Job failed", jobID, t));

Review comment:
       @tillrohrmann , I would wait for @aljoscha to give the opinion of the 
changes to `CompletionExcetpion` contract for `JobClient`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to