JingsongLi commented on a change in pull request #13994:
URL: https://github.com/apache/flink/pull/13994#discussion_r532314905
##########
File path:
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/utils/ParquetSchemaConverter.java
##########
@@ -374,17 +375,33 @@ private static Type convertField(String fieldName,
TypeInformation<?> typeInfo,
GroupType componentGroup = (GroupType)
convertField(LIST_ELEMENT, objectArrayTypeInfo.getComponentInfo(),
Type.Repetition.REQUIRED, legacyMode);
- GroupType elementGroup =
Types.repeatedGroup().named(LIST_ELEMENT);
- elementGroup =
elementGroup.withNewFields(componentGroup.getFields());
- fieldType = Types.buildGroup(repetition)
- .addField(elementGroup)
- .as(OriginalType.LIST)
- .named(fieldName);
+ if (legacyMode) {
+ // LegacyModel is 2 Level List schema
Review comment:
NIT: legacyMode
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
