[ 
https://issues.apache.org/jira/browse/FLINK-20297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243031#comment-17243031
 ] 

Dawid Wysakowicz commented on FLINK-20297:
------------------------------------------

Are there any other cases other than {{Unit}}, which is a very corner case 
scenario. {{Unit}} is a very special type in Scala similar to the {{Void}} 
type. Honestly I'd prefer not to change dozens of classes for that single case.

> Make `SerializerTestBase::getTestData` return List<T>
> -----------------------------------------------------
>
>                 Key: FLINK-20297
>                 URL: https://issues.apache.org/jira/browse/FLINK-20297
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Type Serialization System
>            Reporter: Guowei Ma
>            Assignee: Guowei Ma
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently `SerializerTestBase::getTestData` return T[], which can not be 
> override by the Scala. It means that developer could not add scala serializer 
> test based on `SerializerTestBase`
> So I would propose to change the `SerializerTestBase::getTestData` to return 
> List<T>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to