kl0u commented on a change in pull request #14275:
URL: https://github.com/apache/flink/pull/14275#discussion_r535292580
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkContainer.java
##########
@@ -281,21 +280,19 @@ public FlinkContainer build() {
numTaskManagers,
logBackupDirectory.orElse(null));
} catch (Exception e) {
- throw new RuntimeException("Could not build the
flink-dist image", e);
- } finally {
temporaryFolder.delete();
+ throw new RuntimeException("Could not build the
flink-dist image", e);
}
}
private ImageFromDockerfile buildConfiguredImage(
- String flinkDistName,
Path workersFile,
String baseImage) {
return new ImageFromDockerfile(
"flink-dist-configured")
.withDockerfileFromBuilder(
builder -> builder.from(baseImage)
- .copy("workers", flinkDistName
+ "/conf/workers")
+ .copy("workers",
"flink/conf/workers")
Review comment:
Here we are saying "copy the 'workers' file to the 'flink/conf/workers'"
of the new image, right? What is in the 'workers' file? Shouldn't this be
`/conf/workers`? Also on the master the args are reversed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
