tillrohrmann commented on a change in pull request #14326:
URL: https://github.com/apache/flink/pull/14326#discussion_r539409566
##########
File path: docs/ops/metrics.md
##########
@@ -1654,6 +1654,9 @@ Request metrics aggregated over a subset of all entities
of the respective type:
- `/jobs/metrics?jobs=D,E,F`
- `/jobs/<jobid>/vertices/<vertexid>/subtasks/metrics?subtask=1,2,3`
+<span class="label label-danger">Warning</span> Metric names can contain
special characters (`?`, `&`, `$`, `+`, `/`, `,`, `:`, `=`, `@`, `%`) that you
need to be escape when querying metrics.
Review comment:
```suggestion
<span class="label label-danger">Warning</span> Metric names can contain
special characters (`?`, `&`, `$`, `+`, `/`, `,`, `:`, `=`, `@`, `%`) that you
need to escape when querying metrics.
```
##########
File path: docs/ops/metrics.md
##########
@@ -1654,6 +1654,9 @@ Request metrics aggregated over a subset of all entities
of the respective type:
- `/jobs/metrics?jobs=D,E,F`
- `/jobs/<jobid>/vertices/<vertexid>/subtasks/metrics?subtask=1,2,3`
+<span class="label label-danger">Warning</span> Metric names can contain
special characters (`?`, `&`, `$`, `+`, `/`, `,`, `:`, `=`, `@`, `%`) that you
need to be escape when querying metrics.
Review comment:
Can we link to the rules how to escape these characters, e.g. a table of
URL Escape Characters?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
