zentol commented on a change in pull request #13964:
URL: https://github.com/apache/flink/pull/13964#discussion_r539443934
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
##########
@@ -157,6 +161,22 @@ void start(
@Nonnull SlotRequestId slotRequestId,
@Nonnull AllocationID allocationID);
+ /**
+ * Allocates the available slot with the given allocation id under the
given request id. This method returns
+ * {@code null} if no slot with the given allocation id is available.
+ *
+ * @param slotRequestId identifying the requested slot
+ * @param allocationID the allocation id of the requested available slot
+ * @param requiredSlotProfile requiredSlotProfile for which to allocate
the slot
Review comment:
After looking at the current usages, it looks like we can remove
`@Nullable` and the `allocateAvailableSlot()` variant that does not pass a slot
profile.
The profile is never null, and the method is never called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
