godfreyhe commented on a change in pull request #14337:
URL: https://github.com/apache/flink/pull/14337#discussion_r539812153
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNode.java
##########
@@ -31,6 +32,18 @@
*/
public interface ExecNode<T> {
+ /**
+ * Returns a string which describes this node.
+ * TODO rename to `getDescription` once all ExecNodes do not extend
from FlinkPhysicalRel,
+ * because RelNode already has `getDescription` method.
+ */
+ String getDesc();
Review comment:
no, if this pr is merged before
https://github.com/apache/flink/pull/14315, I will update
https://github.com/apache/flink/pull/14315. and if
https://github.com/apache/flink/pull/14315 is merged before this pr, I will
update ExecPlanDumper
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
