jiasheng55 commented on a change in pull request #14271:
URL: https://github.com/apache/flink/pull/14271#discussion_r540046988
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/CommandLineOptions.java
##########
@@ -26,15 +26,19 @@
* Base class for all options parsed from the command line.
* Contains options for printing help and the JobManager address.
*/
-public abstract class CommandLineOptions {
+public class CommandLineOptions {
Review comment:
Thanks for your review!
This PR adds a new interface `CommandAction`, and its `CommandAction#parse`
method parses command line args to `CommandLineOptions`, but for `--version` or
`--help` command, there is no suited type of `CommandLineOptions`, like
`StopOptions` for `stop` command, so I removed `abstract` to create
`CommandLineOptions` instances directly for `--help` and `--version` commands.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
