Myasuka commented on a change in pull request #14307:
URL: https://github.com/apache/flink/pull/14307#discussion_r540088655
##########
File path: flink-runtime-web/src/test/resources/rest_api_v1.snapshot
##########
@@ -1242,6 +1242,9 @@
},
"unaligned_checkpoints" : {
"type" : "boolean"
+ },
+ "tolerable_failed" : {
Review comment:
how about `tolerable_failed_checkpoints` ?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointConfigInfo.java
##########
@@ -81,6 +83,9 @@
@JsonProperty(FIELD_NAME_UNALIGNED_CHECKPOINTS)
private final boolean unalignedCheckpoints;
+ @JsonProperty(FIELD_NAME_TOLERABLE_FAILED_CHECKPOINT)
+ private final int tolerableFailed;
Review comment:
The same suggestion as above.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointConfigInfo.java
##########
@@ -57,6 +57,8 @@
public static final String FIELD_NAME_UNALIGNED_CHECKPOINTS =
"unaligned_checkpoints";
+ public static final String FIELD_NAME_TOLERABLE_FAILED_CHECKPOINT =
"tolerable_failed";
Review comment:
how about changes below?
```suggestion
public static final String FIELD_NAME_TOLERABLE_FAILED_CHECKPOINTS =
"tolerable_failed_checkpoints";
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
