Myasuka commented on a change in pull request #14341:
URL: https://github.com/apache/flink/pull/14341#discussion_r540118236
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBResourceContainer.java
##########
@@ -143,6 +144,11 @@ public ColumnFamilyOptions getColumnOptions() {
"We currently only support
BlockBasedTableConfig When bounding total memory.");
blockBasedTableConfig = (BlockBasedTableConfig)
tableFormatConfig;
}
+ if (rocksResources.isUsingPartitionedIndex()) {
Review comment:
I think we could overwrite a default full bloom filter if user
configured a filter as this is required for partitioned index feature. We could
add warning logs for this behavior change. Remember to add a `TODO` so that we
could get the `bits` in configured bloom filter in the future once RocksDB
bumped version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
