[
https://issues.apache.org/jira/browse/FLINK-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195041#comment-15195041
]
ASF GitHub Bot commented on FLINK-3115:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56140261
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticSearch2SinkFunction.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.streaming.connectors.elasticsearch2;
+
+import org.apache.flink.api.common.functions.Function;
+import org.apache.flink.api.common.functions.RuntimeContext;
+
+import java.io.Serializable;
+
+/**
+ * Function that creates an {@link org.elasticsearch.action.ActionRequest}
from an element in a Stream.
+ *
+ * <p>
+ * This is used by {@link ElasticSearch2Sink}
+ * to prepare elements for sending them to Elasticsearch. See
+ * <a
href="https://www.elastic.co/guide/en/elasticsearch/client/java-api/current/index_.html";>Index
API</a>
+ * for information about how to format data for adding it to an
Elasticsearch index.
+ *
+ * <p>
+ * Example:
+ *
+ * <pre>{@code
+ * private static class MyIndexRequestBuilder implements
IndexRequestBuilder<String> {
+ *
+ * public IndexRequest createIndexRequest(String element,
RuntimeContext ctx) {
+ * Map<String, Object> json = new HashMap<>();
+ * json.put("data", element);
+ *
+ * return Requests.indexRequest()
+ * .index("my-index")
+ * .type("my-type")
+ * .source(json);
+ * }
+ * }
+ * }</pre>
+ *
+ * @param <T> The type of the element handled by this {@code
IndexRequestBuilder}
+ */
+
+public interface ElasticSearch2SinkFunction<T> extends Serializable,
Function {
+ void sink(T element, RuntimeContext ctx, RequestIndexer indexer);
--- End diff --
we should find a better name for this method, preferably consistent with
other sinks.
> Update Elasticsearch connector to 2.X
> -------------------------------------
>
> Key: FLINK-3115
> URL: https://issues.apache.org/jira/browse/FLINK-3115
> Project: Flink
> Issue Type: Improvement
> Components: Streaming Connectors
> Affects Versions: 0.10.0, 1.0.0, 0.10.1
> Reporter: Maximilian Michels
> Assignee: Suneel Marthi
> Fix For: 1.0.0
>
>
> The Elasticsearch connector is not up to date anymore. In version 2.X the API
> changed. The code needs to be adapted. Probably it makes sense to have a new
> class {{ElasticsearchSink2}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
