[ 
https://issues.apache.org/jira/browse/FLINK-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195207#comment-15195207
 ] 

ASF GitHub Bot commented on FLINK-3492:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1794#discussion_r56154469
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
 ---
    @@ -921,11 +921,20 @@ public ActorGateway 
createActivatorDeactivator(ActorSystem actorSystem, UUID lea
        // 
------------------------------------------------------------------------
     
        private class ScheduledTrigger extends TimerTask {
    +           private final long processingInterval;
    +           private long lastCheckpoint = 0;
    +
    +           public ScheduledTrigger(long guaranteedInterval) {
    +                   this.processingInterval = guaranteedInterval;
    +           }
     
                @Override
                public void run() {
                        try {
    -                           triggerCheckpoint(System.currentTimeMillis());
    +                           long time = lastCheckpoint;
    --- End diff --
    
    where do you update `lastCheckpoint`? If I'm not mistaken, then it should 
always stay `0`.


> Allow users to define a min pause between checkpoints
> -----------------------------------------------------
>
>                 Key: FLINK-3492
>                 URL: https://issues.apache.org/jira/browse/FLINK-3492
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>
> FLINK-3051 introduced already a filed in the {{CheckpointConfig}} to specify 
> a min pause between checkpoints.
> In high-load situations (big state), jobs might spend their entire time 
> creating snapshots, not processing data. With a min pause between 
> checkpoints, users can guarantee that there is a certain time-span the system 
> can use for doing some actual data processing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to