[
https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195276#comment-15195276
]
ASF GitHub Bot commented on FLINK-2732:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1790#discussion_r56159993
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -781,6 +787,32 @@ class TaskManager(
}
}
+ private def handleRequestTaskManagerLog
+ (sender: ActorRef, requestType: LogTypeRequest, jobManager: ActorRef):
+ Unit = {
+ if (blobService.isDefined && jobManager.path.address.host.isDefined) {
+ //create new Thread to upload log, to not block the TM for too long
+ new Thread() {
+ override def run(): Unit = {
+ val jmHost = jobManager.path.address.host.get
+ val port = blobService.get.getPort
+ val logFilePath = System.getProperty("log.file");
+ val file: File = requestType match {
+ case LogFileRequest => new File(logFilePath);
+ case StdOutFileRequest =>
+ new File(logFilePath.substring(0, logFilePath.length - 4) +
".out");
+ }
+
+ val client: BlobClient = new BlobClient(new
InetSocketAddress(jmHost, port))
+
+ sender ! client.put(new FileInputStream(file))
+ }
+ }.run()
--- End diff --
This won't start a new thread but simply call the just overwritten `run`
method. Use `start` instead. Furthermore, it is not encouraged to extend the
Thread class. It is better to implement a `Runnable` or even better avoiding to
deal with raw threads at all. I guess it would be easier to simply spawn a
`Future` which is executed by a respective `ExecutionContext`.
> Add access to the TaskManagers' log file and out file in the web dashboard.
> ---------------------------------------------------------------------------
>
> Key: FLINK-2732
> URL: https://issues.apache.org/jira/browse/FLINK-2732
> Project: Flink
> Issue Type: Sub-task
> Components: Webfrontend
> Affects Versions: 0.10.0
> Reporter: Stephan Ewen
> Assignee: Chesnay Schepler
> Fix For: 1.0.0
>
>
> Add access to the TaskManagers' log file and out file in the web dashboard.
> This needs addition on the server side, as the log files need to be
> transferred to the JobManager via the blob server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
