[
https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195397#comment-15195397
]
ASF GitHub Bot commented on FLINK-2732:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1790#discussion_r56173641
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -234,7 +235,9 @@ public WebRuntimeMonitor(
.GET("/jobs/:jobid/checkpoints", handler(new
JobCheckpointsHandler(currentGraphs)))
.GET("/taskmanagers", handler(new
TaskManagersHandler(DEFAULT_REQUEST_TIMEOUT)))
- .GET("/taskmanagers/:" +
TaskManagersHandler.TASK_MANAGER_ID_KEY, handler(new
TaskManagersHandler(DEFAULT_REQUEST_TIMEOUT)))
+ .GET("/taskmanagers/:" +
TaskManagersHandler.TASK_MANAGER_ID_KEY + "/metrics", handler(new
TaskManagersHandler(DEFAULT_REQUEST_TIMEOUT)))
+ .GET("/taskmanagers/:" +
TaskManagersHandler.TASK_MANAGER_ID_KEY + "/log", new
TaskManagerLogHandler(retriever, actorSystem.dispatcher(),
jobManagerAddressPromise.future(), timeout, true))
--- End diff --
I think we shouldn't use the dispatcher of the `ActorSystem` as the
`ExecutorService` here. The `ActorSystem` is usually the `ActorSystem` of the
JM and we shouldn't put load on its `ThreadPool`. I would rather use a
dedicated `ThreadPool` for the execution of the futures.
> Add access to the TaskManagers' log file and out file in the web dashboard.
> ---------------------------------------------------------------------------
>
> Key: FLINK-2732
> URL: https://issues.apache.org/jira/browse/FLINK-2732
> Project: Flink
> Issue Type: Sub-task
> Components: Webfrontend
> Affects Versions: 0.10.0
> Reporter: Stephan Ewen
> Assignee: Chesnay Schepler
> Fix For: 1.0.0
>
>
> Add access to the TaskManagers' log file and out file in the web dashboard.
> This needs addition on the server side, as the log files need to be
> transferred to the JobManager via the blob server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
