wuchong commented on a change in pull request #14415:
URL: https://github.com/apache/flink/pull/14415#discussion_r545620784
##########
File path:
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonRowFormatFactoryTest.java
##########
@@ -128,6 +152,14 @@ private void testSchemaDeserializationSchema(Map<String,
String> properties) {
assertEquals(expected2, actual2);
}
+ private void
testSchemaDeserializationSchemaIgnoreParseErrors(Map<String, String>
properties) {
Review comment:
We don't need to extract a method if this method is only be invoked in
one place.
##########
File path:
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonRowFormatFactoryTest.java
##########
@@ -91,6 +103,18 @@ public void testJsonSchema() {
testJsonSchemaDeserializationSchema(properties);
}
+ @Test
+ public void testJsonSchemaIgnoreParseErrors() {
Review comment:
I think `testSchemaIgnoreParseErrors()` is enough to cover the bug. We
can't permute all possible combination of configurations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
