[
https://issues.apache.org/jira/browse/FLINK-15314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251672#comment-17251672
]
Matthias commented on FLINK-15314:
----------------------------------
[~lining]: While working on
[FLIP-102|https://cwiki.apache.org/confluence/display/FLINK/FLIP-102%3A+Add+More+Metrics+to+TaskManager],
we decided to not continue extending the TaskManagerDetailsHandler response.
Instead, the user should rather use the metrics REST endpoint instead.
Considering that the goal would be to remove the code, is it worth doing this
refactoring?
> To refactor duplicated code in
> TaskManagerDetailsHandler#createTaskManagerMetricsInfo
> -------------------------------------------------------------------------------------
>
> Key: FLINK-15314
> URL: https://issues.apache.org/jira/browse/FLINK-15314
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Metrics, Runtime / REST
> Reporter: lining
> Priority: Major
>
> As
> [code|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/TaskManagerDetailsHandler.java#L119-L142]
> show, use hard codes to define metrics' name. Could we unify where to
> register and get metrics?
> * propose
> ** move metrics'name define in MetricUtils to MetricNames
> ** the all get the name form MetricNames
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
