twalthr commented on a change in pull request #14420:
URL: https://github.com/apache/flink/pull/14420#discussion_r545746409
##########
File path:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
##########
@@ -71,19 +82,34 @@
private final int arity;
+ private final @Nullable LinkedHashMap<String, Integer> positionByName;
+
private transient boolean[] mask;
+ private transient Row reuseRowPositionBased;
+
public RowSerializer(TypeSerializer<?>[] fieldSerializers) {
- this(fieldSerializers, false);
+ this(fieldSerializers, null, false);
+ }
+
+ public RowSerializer(
+ TypeSerializer<?>[] fieldSerializers,
+ @Nullable LinkedHashMap<String, Integer>
positionByName) {
+ this(fieldSerializers, positionByName, false);
}
@SuppressWarnings("unchecked")
- public RowSerializer(TypeSerializer<?>[] fieldSerializers, boolean
legacyModeEnabled) {
+ public RowSerializer(
+ TypeSerializer<?>[] fieldSerializers,
+ @Nullable LinkedHashMap<String, Integer> positionByName,
+ boolean legacyModeEnabled) {
Review comment:
+1 I can open a PR for it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
