kl0u commented on a change in pull request #14312:
URL: https://github.com/apache/flink/pull/14312#discussion_r545953329
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessorFactory.java
##########
@@ -143,7 +150,20 @@ else if (configuredInput instanceof
StreamConfig.SourceInputConfig) {
jobConfig
);
- inputs = selectableSortingInputs.getSortingInputs();
+ StreamTaskInput<?>[] sortedInputs =
selectableSortingInputs.getSortedInputs();
+ StreamTaskInput<?>[] passThroughInputs =
selectableSortingInputs.getPassThroughInputs();
+ int sortedIndex = 0;
+ int passThroughIndex = 0;
+ for (int i = 0; i < inputs.length; i++) {
+ if (requiresSorting(inputConfigs[i])) {
+ inputs[i] = sortedInputs[sortedIndex];
+ sortedIndex++;
+ } else {
+ inputs[i] =
passThroughInputs[passThroughIndex];
+ passThroughIndex++;
+ }
+ }
+ inputs = selectableSortingInputs.getSortedInputs();
Review comment:
This line seems to be undoing what you did before, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
