blublinsky commented on pull request #14439: URL: https://github.com/apache/flink/pull/14439#issuecomment-749078816
Added unit test > On Dec 20, 2020, at 8:53 PM, Yang Wang <[email protected]> wrote: > > > @blublinsky <https://github.com/blublinsky> Could you please refine the content of this PR? It have too many unrelated changes? Also the commit message also needs to be updated based on the contribution guideline[1]. Maybe it could be [FLINK-20664][k8s] Support setting service account for TaskManager pod. > Another important thing is we should add some corresponding unit tests for this change. > > [1]. https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#commit-naming-conventions <https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#commit-naming-conventions> > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <https://github.com/apache/flink/pull/14439#issuecomment-748727909>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGA5MG6XU4ASLABMXXNLF2DSV22BFANCNFSM4VDR4O6A>. > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
