Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1796#issuecomment-197237551
Classic case of "The Most Beautiful Code I Never Wrote":
https://www.safaribooksonline.com/library/view/beautiful-code/9780596510046/ch03.html
There is no test (old one didn't have one either) and I'm assuming this is
not easy to test against the actual API in an automated way. I'm assuming you
tested it manually?
+1 to merge as it is a great improvement compared to the old source.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
