[
https://issues.apache.org/jira/browse/FLINK-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197124#comment-15197124
]
ASF GitHub Bot commented on FLINK-1964:
---------------------------------------
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1796#issuecomment-197237551
Classic case of "The Most Beautiful Code I Never Wrote":
https://www.safaribooksonline.com/library/view/beautiful-code/9780596510046/ch03.html
There is no test (old one didn't have one either) and I'm assuming this is
not easy to test against the actual API in an automated way. I'm assuming you
tested it manually?
+1 to merge as it is a great improvement compared to the old source.
> Rework TwitterSource to use a Properties object instead of a file path
> ----------------------------------------------------------------------
>
> Key: FLINK-1964
> URL: https://issues.apache.org/jira/browse/FLINK-1964
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 0.9
> Reporter: Robert Metzger
> Assignee: Carlos Curotto
> Priority: Minor
> Labels: starter
>
> The twitter connector is very hard to use on a cluster because it expects the
> property file to be present on all nodes.
> It would be much easier to ask the user to pass a Properties object
> immediately.
> Also, the javadoc of the class stops in the middle of the sentence.
> It was not obvious to me how the two examples TwitterStreaming and
> TwitterTopology differ. Also, there is a third TwitterStream example in the
> streaming examples.
> The documentation of the Twitter source refers to the non existent
> TwitterLocal class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
