[
https://issues.apache.org/jira/browse/FLINK-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197162#comment-15197162
]
ASF GitHub Bot commented on FLINK-3609:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1797#discussion_r56312442
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala
---
@@ -29,50 +29,45 @@ object FlinkRuleSets {
*/
val DATASET_OPT_RULES: RuleSet = RuleSets.ofList(
- // filter rules
+ // push a filter into a join
FilterJoinRule.FILTER_ON_JOIN,
+ // push filter into the children of a join
FilterJoinRule.JOIN,
- FilterMergeRule.INSTANCE,
- FilterAggregateTransposeRule.INSTANCE,
+ // push filter through an aggregation
+ FlinkFilterAggregateTransposeRule.INSTANCE,
- // push and merge projection rules
+ // aggregation and projection rules
AggregateProjectMergeRule.INSTANCE,
- ProjectMergeRule.INSTANCE,
--- End diff --
Should be covered by the rules to merge Calcs.
> Revisit selection of Calcite rules
> ----------------------------------
>
> Key: FLINK-3609
> URL: https://issues.apache.org/jira/browse/FLINK-3609
> Project: Flink
> Issue Type: Task
> Components: Table API
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
>
> We should revisit the selection of Calcite rules, e.g., remove rule to
> reorder joins or join inputs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
