HuangZhenQiu commented on a change in pull request #8952: URL: https://github.com/apache/flink/pull/8952#discussion_r547752610
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/failurerate/FailureRater.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.failurerate; + +import org.apache.flink.metrics.Meter; +import org.apache.flink.util.clock.Clock; + +/** + * Failure rate interface. + */ +public interface FailureRater extends Meter { Review comment: ThresholdMeter should be good enough, but do you see any other usage for ThresholdMeter. I would like to keep the naming here for current usage. We can change it if there is a need later. For the interface, I guess we can keep exceedsFailureRate and markFailure. As you pointed out, markEvent takes the count of occurrence as input. But we need a timestamp as parameter here for implementation and test purposes. (please check the TimestampBasedFailureRaterTest). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
