HuangZhenQiu commented on a change in pull request #8952:
URL: https://github.com/apache/flink/pull/8952#discussion_r547808056



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManager.java
##########
@@ -246,6 +269,10 @@ private void requestNewWorker(WorkerResourceSpec 
workerResourceSpec) {
                                                                
workerResourceSpec,
                                                                count,
                                                                exception);
+                                               if (recordWorkerFailure()) {
+                                                       // if exceed failure 
rate try to slow down
+                                                       
tryResetWorkerCreationCoolDown();
+                                               }

Review comment:
       The behavior is different in onWorkerTerminated as we only record 
failure events for workers that not yet registered. Probably just leave it as 
it is for now?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to