XComp commented on pull request #14440:
URL: https://github.com/apache/flink/pull/14440#issuecomment-750117054


   > I don't quite like the phrasing.
   > 
   > * we should first list that these are the actual values used by Flink, 
then follow with the explanation
   > * do not say "configured by the _user_"; the values may be set by the 
person submitting the job, the devops guy, some framework (e.g., AWS) or even 
Flink itself
   > * do not mention flink-conf.yaml, because these options may be set on the 
command-line
   > * "comes up with the missing values" sounds a bit...unsophisticated? Not 
sure how to describe it.
   > 
   > I would suggest the following:
   > 
   > ```
   > This column shows the values that are actually used by Flink. These may 
differ from the configured values; Flink may adjust them to fit the actual 
setup, and automatically derives values that were not explicitly configured.
   > ```
   
   Sounds good 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to