HuangZhenQiu edited a comment on pull request #8952: URL: https://github.com/apache/flink/pull/8952#issuecomment-751315528
@xintongsong Thanks for the comments. I do like the simplified version after grouping classes and utils together. For the TimestampBasedFailureRater, I would prefer to leave it as it is. Otherwise, we need to split the 100 lines of code into ThresholdMeter, TimestampBasedThresholdMeter, and FailureRater. I think we can keep it simple and refactor it once it can be usable in other components. How do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
