sv3ndk opened a new pull request #15:
URL: https://github.com/apache/flink-training/pull/15


   hi,
   
   While reading Flink documentation, I noticed that 
[learn-flink/etl.html](https://ci.apache.org/projects/flink/flink-docs-release-1.12/learn-flink/etl.html)
 has a link at the bottom of the page to 
https://github.com/apache/flink-training/tree/release-1.12/rides-and-fares, 
which does not exists yet.
   
   I tried to bump up the Flink version here to 1.12 and everything seems to 
work (I didn't do all the exercises though).
   
   Based on the gradle warning I saw during `./gradlew test shadowJar`, I also 
removed the following statements from the scala exercises: 
   ```
    env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime)
   ```
   since it's my understanding that this method is now deprecated and 
event-time characteristics is the default anyway (cf 
https://github.com/apache/flink/blob/release-1.12/flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala#L411
 ).
   
   Hope this helps, thanks for making this training freely available :)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to