pnowojski commented on a change in pull request #14460:
URL: https://github.com/apache/flink/pull/14460#discussion_r549609731
##########
File path: docs/_includes/generated/all_taskmanager_section.html
##########
@@ -18,7 +18,7 @@
<td><h5>task.cancellation.timeout</h5></td>
<td style="word-wrap: break-word;">180000</td>
<td>Long</td>
- <td>Timeout in milliseconds after which a task cancellation times
out and leads to a fatal TaskManager error. A value of 0 deactivates the watch
dog.</td>
+ <td>Timeout in milliseconds after which a task cancellation times
out and leads to a fatal TaskManager error. A value of 0 deactivates the watch
dog. Notice that a task cancellation is different from a task failure. So task
cancellation timeout does not apply to task closing/clean-up caused by a task
failure.</td>
Review comment:
1. I would suggest to add clean shutdown mention, because up till the
moment I started reading your PR, I was sure that the FLINK-18983 is all about
clean shutdown 😓 So the mis conception can go in both directions .
2. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
