zentol opened a new pull request #14519:
URL: https://github.com/apache/flink/pull/14519


   This PR resolves various issues related to the placement of generated 
sources and their respective schemas.
   
   - schemas are always placed under `resources/`, as it seems appropriate 
(random directories under src/main/ are always a tad weird)
   - generated production code is put under target/generated-sources
   - generated test code is put under target/generated-test-sources
   - generated classes are no longer checked into git
   
   This change does not affect packaging, or how maven/IntelliJ works, as these 
directories are by convention used for the very purpose of storing generated 
content.
   
   The main benefit here is these files are cleaned up when doing a `mvn 
clean`. As is stands, if you checked out master and compiled Flink, switching 
back to 1.11 causes the compilation to fail because of generated classes in the 
source tree that are not cleaned up automatically, requiring manual 
intervention (i.e., going in and deleting files).
   It also just homogenizes the whole affair across our modules.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to