xintongsong commented on a change in pull request #8952: URL: https://github.com/apache/flink/pull/8952#discussion_r549959072
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/failurerate/TimestampBasedFailureRater.java ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.failurerate; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.api.common.time.Time; +import org.apache.flink.runtime.execution.ThresholdExceedException; + +import java.util.ArrayDeque; +import java.util.Queue; +import java.util.function.Supplier; + +/** + * A timestamp queue based failure rater implementation. + */ +public class TimestampBasedFailureRater implements ThresholdMeter { Review comment: I believe a clear abstraction of concepts should be prior to the implementation details (what the error messages say, how the factories should look like, etc). Compared with `Meter`, conceptually the only additional function this implementation class provides is `checkAgainstThreshold`. Concerning the implementation issues you mentioned, they should be adjusted with respect to the underlying concepts. * `checkAgainstThreshold` can only say that current rate `x` has reached the threshold `y`, and we can mention that the rate is for starting container failure in `ActiveResourceManager` for logging. * We can change `fromConfiguration(Configuration config)` to `withMinuteThreshold(double threshold)` and parse the configuration option in `ActiveResourceManagerFactory`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
