[
https://issues.apache.org/jira/browse/FLINK-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201746#comment-15201746
]
ASF GitHub Bot commented on FLINK-3633:
---------------------------------------
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1818#discussion_r56683381
--- Diff: flink-core/src/main/java/org/apache/flink/util/UserCodeValue.java
---
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.io.Serializable;
+import java.util.Arrays;
+
+/**
+ * Value wrapper which automatically transfers the data as a serialized
byte array. Upon reception
+ * the serialized byte array has to be explicitly deserialized providing a
class loader with the
+ * correct classes.
+ *
+ * This is useful if the object would get deserialized by the system class
loader which does not
+ * have access to the user code classes.
+ * @param <T>
+ */
+public class UserCodeValue<T extends Serializable> implements Serializable
{
+ private static final long serialVersionUID = 6903400536729445732L;
+
+ private transient T value;
+
+ private byte[] serializedValue;
+
+ public UserCodeValue(T value) {
+ this.value = value;
+ }
+
+ public T getValue() {
+ if (value == null && serializedValue != null) {
+ throw new NullPointerException("The user code value has
not been serialied. Call " +
--- End diff --
"serialized" -> "deserialized"?
> Job submission silently fails when using user code types
> --------------------------------------------------------
>
> Key: FLINK-3633
> URL: https://issues.apache.org/jira/browse/FLINK-3633
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Blocker
> Fix For: 1.1.0
>
>
> With the changes introduced by FLINK-3327, it is no longer possible to run
> remote Flink jobs which work on user code types. The reason is that now the
> {{ExecutionConfig}} is directly stored in the {{JobGraph}} which is sent as
> an Akka message to the {{JobManager}}. Per default, user code types are
> automatically detected and registered in the {{ExecutionConfig}}. When
> deserializing a {{JobGraph}} whose {{ExecutionConfig}} contains user code
> classes the user code class loader is consequently required. However, Akka
> does not have access to it and uses the system class loader. This causes that
> Akka silently discards the {{SubmitJob}} message which cannot be deserialized
> because of a {{ClassNotFoundException}}.
> I propose to not sent the {{ExecutionConfig}} explicitly with the
> {{JobGraph}} and, thus, to partially revert the changes to before FLINK-3327.
> Before, the {{ExectuionConfig}} was serialized into the job configuration and
> deserialized on the {{TaskManager}} using the proper user code class loader.
> In order to reproduce the problem you can submit the following job to a
> remote cluster.
> {code}
> public class Job {
> public static class CustomType {
> private final int value;
> public CustomType(int value) {
> this.value = value;
> }
> @Override
> public String toString() {
> return "CustomType(" + value + ")";
> }
> }
> public static void main(String[] args) throws Exception {
> ExecutionEnvironment env =
> ExecutionEnvironment.createRemoteEnvironment(Address, Port, PathToJar);
> env.getConfig().disableAutoTypeRegistration();
> DataSet<Integer> input = env.fromElements(1,2,3,4,5);
> DataSet<CustomType> customTypes = input.map(new
> MapFunction<Integer, CustomType>() {
> @Override
> public CustomType map(Integer integer) throws Exception
> {
> return new CustomType(integer);
> }
> });
> customTypes.print();
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
