zentol commented on a change in pull request #14399:
URL: https://github.com/apache/flink/pull/14399#discussion_r550135003
##########
File path: flink-scala-shell/start-script/start-scala-shell.sh
##########
@@ -86,11 +86,15 @@ if [[ ($MODE = "local") || ($MODE = "remote") ]]
then
LOG4J_CONFIG=log4j.properties
LOGBACK_CONFIG=logback.xml
-elif [[ $1 = "yarn" ]]
+elif [[ $MODE = "yarn" ]]
Review comment:
maybe we could simplify this further:
```
if yarn {
use the session files
else {
use default files
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
