rkhachatryan commented on a change in pull request #14507:
URL: https://github.com/apache/flink/pull/14507#discussion_r550191413
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -696,7 +697,24 @@ private void stopTaskExecutorServices() throws Exception {
partitionStateChecker,
getRpcService().getExecutor());
- taskMetricGroup.gauge(MetricNames.IS_BACKPRESSURED,
task::isBackPressured);
+ taskMetricGroup.gauge(MetricNames.IS_BACK_PRESSURED,
task::isBackPressured);
Review comment:
`isBackPressured` is now used more often, which might lead to many
`volatile` reads (`Future.isDone`).
However, these reads can be eliminated by exiting the loop once **some**
future is not done (instead of `!allOf(futures).isDone`).
It would also make the code more readable IMO.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
