zentol commented on a change in pull request #14520:
URL: https://github.com/apache/flink/pull/14520#discussion_r550231686
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/generated/AggsHandleFunction.java
##########
@@ -30,9 +30,10 @@
*/
public interface AggsHandleFunction extends AggsHandleFunctionBase {
- /**
- * Gets the result of the aggregation from the current accumulators.
- * @return the final result (saved in a row) of the current
accumulators.
- */
- RowData getValue() throws Exception;
+ /**
+ * Gets the result of the aggregation from the current accumulators.
+ *
+ * @return the final result (saved in a row) of the current accumulators.
+ */
+ RowData getValue() throws Exception;
Review comment:
Yes. From what I could gather these are used for wrapping/generating
code, but not actually generated themselves. The naming is indeed problematic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
