rkhachatryan commented on pull request #10847: URL: https://github.com/apache/flink/pull/10847#issuecomment-752705617
@BrantZheng, `TwoPhaseCommitSinkFunction` currently doesn't support: 1. retrying commits (in case of transient failures) 2. retrying rollbacks 3. distinguishing between transactions started during this run and restored from the state; ignore commit failures (with reason “unknown”) for the latter; this is a consequence of a lack of timeouts 4. when committing a group of transactions: an option to stop commits as soon as one failed; otherwise consistency can be violated (if the failure was transient then failed commit and all the further commits will be retried later) 5. in JDBC, transaction timeouts aren’t used to ignore commit failures, as most DBs don’t support them There was an effort to unify these two functions (FLIP-94). But later it was superseeded by the New Sink API. So we decided to merge this PR as it is and then migrate to the new API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
