pnowojski commented on a change in pull request #14526:
URL: https://github.com/apache/flink/pull/14526#discussion_r551385425
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -400,9 +404,23 @@ protected void
processInput(MailboxDefaultAction.Controller controller) throws E
controller.allActionsCompleted();
return;
}
- CompletableFuture<?> jointFuture = getInputOutputJointFuture(status);
- MailboxDefaultAction.Suspension suspendedDefaultAction =
controller.suspendDefaultAction();
- assertNoException(jointFuture.thenRun(suspendedDefaultAction::resume));
+
+ final Suspension suspension = controller.suspendDefaultAction();
Review comment:
I have shortened it while you were doing the review, when I was changing
the semantic of `idleTimeMsPerSecond` metric. Can you change the fixup commit
if it's good enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
