tillrohrmann commented on a change in pull request #13565:
URL: https://github.com/apache/flink/pull/13565#discussion_r551400670
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointStore.java
##########
@@ -84,7 +85,7 @@ default CompletedCheckpoint getLatestCheckpoint(boolean
isPreferCheckpointForRec
*
* @param jobStatus Job state on shut down
*/
- void shutdown(JobStatus jobStatus) throws Exception;
+ void shutdown(JobStatus jobStatus, CheckpointsCleaner
checkpointsCleaner, Runnable postCleanup) throws Exception;
Review comment:
Why do we need the `postCleanup`? In the current code base I couldn't
find a single usage where we don't pass `() -> {}` @rkhachatryan and
@pnowojski? If this is not needed, can we get rid of it? I think it does not
make a very nice API with the no-ops.
Moreover, it would be nice if we could update the JavaDocs if we change the
signature of interfaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
