[
https://issues.apache.org/jira/browse/FLINK-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197395#comment-15197395
]
ASF GitHub Bot commented on FLINK-2997:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1776#discussion_r56343356
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/dataproperties/GlobalProperties.java
---
@@ -80,9 +83,15 @@ public void setHashPartitioned(FieldList
partitionedFields) {
this.partitioningFields = partitionedFields;
this.ordering = null;
}
-
- public void setRangePartitioned(Ordering ordering) {
+ /**
+ * Set the parameters for range partition.
+ *
+ * @param ordering Order of the partitioned fields
+ * @param distribution The data distribution for range partition. User
can supply a customized data distribution,
+ * also the data distribution can be null.
+ */
+ public void setRangePartitioned(Ordering ordering, DataDistribution
distribution) {
--- End diff --
I know you've changed this part before, but could you add a
`setRangePartitioned(Ordering ordering)` method which can be used if no
`DataDistribution` is provided? Would be nicer than passing `null` everywhere.
> Support range partition with user customized data distribution.
> ---------------------------------------------------------------
>
> Key: FLINK-2997
> URL: https://issues.apache.org/jira/browse/FLINK-2997
> Project: Flink
> Issue Type: New Feature
> Reporter: Chengxiang Li
>
> This is a followup work of FLINK-7, sometime user have better knowledge of
> the source data, and they can build customized data distribution to do range
> partition more efficiently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)