rkhachatryan commented on a change in pull request #13565:
URL: https://github.com/apache/flink/pull/13565#discussion_r551426315
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointStore.java
##########
@@ -84,7 +85,7 @@ default CompletedCheckpoint getLatestCheckpoint(boolean
isPreferCheckpointForRec
*
* @param jobStatus Job state on shut down
*/
- void shutdown(JobStatus jobStatus) throws Exception;
+ void shutdown(JobStatus jobStatus, CheckpointsCleaner
checkpointsCleaner, Runnable postCleanup) throws Exception;
Review comment:
`postCleanup` is used by `checkpointsCleaner` but not in case of
shutting down. I agree, it should be removed (by pushing down to
`DefaultCompletedCheckpointStore`) and javadoc added. My bad.
I've created FLINK-20847 to address this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
