curcur commented on a change in pull request #14546:
URL: https://github.com/apache/flink/pull/14546#discussion_r551790228
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.html
##########
@@ -91,6 +91,7 @@
<th nzSortKey="alignment.processed" nzShowSort><strong>Processed
(persisted) Data</strong></th>
<th nzSortKey="alignment.duration" nzShowSort><strong>Alignment
Duration</strong></th>
<th nzSortKey="start_delay" nzShowSort><strong>Start
Delay</strong></th>
+ <th nzSortKey="unaligned_checkpoint" nzShowSort><strong>Unaligned
Checkpoint</strong></th>
Review comment:
you sure...? The meaning of "Aligned" is ambiguous, and I do not think
it is straightforward to users that "Aligned" means "not completed as an
unaligned checkpoint"?
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.html
##########
@@ -91,6 +91,7 @@
<th nzSortKey="alignment.processed" nzShowSort><strong>Processed
(persisted) Data</strong></th>
<th nzSortKey="alignment.duration" nzShowSort><strong>Alignment
Duration</strong></th>
<th nzSortKey="start_delay" nzShowSort><strong>Start
Delay</strong></th>
+ <th nzSortKey="unaligned_checkpoint" nzShowSort><strong>Unaligned
Checkpoint</strong></th>
Review comment:
you sure...? The meaning of "Aligned" is ambiguous, and I do not think
it is straightforward for users that "Aligned" means "not completed as an
unaligned checkpoint"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
