rmetzger commented on a change in pull request #14583: URL: https://github.com/apache/flink/pull/14583#discussion_r553799205
########## File path: docs/page/css/bootstrap.min.css ########## @@ -0,0 +1,5 @@ +/*! + * Bootstrap v3.3.4 (http://getbootstrap.com) + * Copyright 2011-2015 Twitter, Inc. + * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE) Review comment: I believe we should mention this dependency in the `NOTICE` file and add a copy of the license to `licenses/LICENSE.bootstrap`. ########## File path: NOTICE ########## @@ -9,6 +9,10 @@ See bundled license files for details. - jQuery v3.5.1 | (c) JS Foundation and other contributors -> in "docs/page/js/jquery.min.js" +- Bootstrap v3.3.4 (http://getbootstrap.com) Copyright 2011-2015 Twitter, Inc. + -> css in "docs/page/css/bootstrap.min.css" + -> js in "docs/page/js/bootstrap.min.js" + -> fonts in "docs/page/fonts" Review comment: ```suggestion - Bootstrap v3.3.4 (http://getbootstrap.com) Copyright 2011-2015 Twitter, Inc. -> css in "docs/page/css/bootstrap.min.css" -> js in "docs/page/js/bootstrap.min.js" -> fonts in "docs/page/fonts" Note: The "docs/page/fonts/glyphicons-halflings*" fonts are included in Bootstrap, and licensed under the same license as Boostrap. See https://glyphicons.com/old/license.html#old-halflings-bootstrap for more information. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
