wangyang0918 commented on a change in pull request #14570:
URL: https://github.com/apache/flink/pull/14570#discussion_r554530957
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClientTest.java
##########
@@ -456,6 +461,20 @@ public void
testCheckAndUpdateConfigMapWhenReplaceConfigMapFailed() throws Excep
}
}
+ @Test
+ public void testWatchConfigMaps() throws Exception {
+ flinkKubeClient.watchConfigMaps(TESTING_CONFIG_MAP_NAME, new
NoOpWatchCallbackHandler<>());
Review comment:
I used to believe that generating a kube config file for
`MockKubernetesServer` is a little difficult. Because we need to generate and
set proper certificate authority file. But after more investigation, I find
that we could easily skip tls verification. So I will update the test to make
it more appropriate, which should fail when the
`config.setNamespace(namespace)` is not called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
