yuruguo commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r555664377
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##########
@@ -334,18 +334,32 @@
.stringType()
.noDefaultValue()
.withDescription(
- "A general option to probe Hadoop configuration
through prefix 'flink.hadoop.'. Flink will remove the prefix to get <key> (from
<a
href=\"https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/core-default.xml\";>core-default.xml</a>
"
- + "and <a
href=\"https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml\";>hdfs-default.xml</a>)
then set the <key> and value to Hadoop configuration. "
- + "For example,
flink.hadoop.dfs.replication=5 in Flink configuration and convert to
dfs.replication=5 in Hadoop configuration.");
+ Description.builder()
+ .text(
+ "A general option to probe Hadoop
configuration through prefix 'flink.hadoop.'. Flink will remove the prefix to
get <key> (from %s and %s) then set the <key> and value to Hadoop
configuration."
+ + " For example,
flink.hadoop.dfs.replication=5 in Flink configuration and convert to
dfs.replication=5 in Hadoop configuration.",
+ link(
+
"https://hadoop.apache.org/docs/r2.4.1/hadoop-project-dist/hadoop-common/core-default.xml";,
Review comment:
Thanks for your review again @tillrohrmann.
Because I found that configuration option `yarn.application-attempts` is
based on v2.4.1, so I continue to use 2.4.1 for alignment. If unbundling with a
specific version is a better way, then I will use the most recent stable
version instead, including `yarn.application-attempts`.
If it's ok, I will update again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
