echauchot commented on a change in pull request #14510:
URL: https://github.com/apache/flink/pull/14510#discussion_r555824498
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
##########
@@ -137,11 +156,18 @@ public AbstractMetricGroup(MetricRegistry registry,
String[] scope, A parent) {
// if no variables are excluded (which is the default!) we re-use the
general variables map
// to save space
return internalGetAllVariables(
- excludedVariables.isEmpty() ? 0 : reporterIndex,
excludedVariables);
+ filter,
+ excludedVariables.isEmpty() ? 0 : reporterIndex,
+ excludedVariables,
+ delimiter);
}
private Map<String, String> internalGetAllVariables(
- int cachingIndex, Set<String> excludedVariables) {
+ CharacterFilter filter,
+ int cachingIndex,
+ Set<String> excludedVariables,
+ char delimiter) {
+ CharacterFilter newFilter = wrapWithDefaultFilter(filter, delimiter);
Review comment:
besides I don't think that testing `cachingIndex > 0` is enough to
detect that the call was done by a reporter because if excluded variables are
empty `cachingIndex` is set to 0 (to save memory space) even when the call is
done by a reporter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
