XComp commented on a change in pull request #14584:
URL: https://github.com/apache/flink/pull/14584#discussion_r556320074
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java
##########
@@ -425,12 +426,12 @@ public void setStrictlyCoLocatedWith(JobVertex
strictlyCoLocatedWith) {
"Strict co-location requires that both vertices are in the
same slot sharing group.");
}
- CoLocationGroup thisGroup = this.coLocationGroup;
- CoLocationGroup otherGroup = strictlyCoLocatedWith.coLocationGroup;
+ CoLocationGroupImpl thisGroup = this.coLocationGroup;
+ CoLocationGroupImpl otherGroup = strictlyCoLocatedWith.coLocationGroup;
Review comment:
The idea was to have a readonly interface as the colocation groups do
not need to be changed after initialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
