zentol commented on a change in pull request #13551:
URL: https://github.com/apache/flink/pull/13551#discussion_r556428858
##########
File path: flink-runtime/pom.xml
##########
@@ -509,6 +509,16 @@ under the License.
<!-- It is useless due to the
way Flink does branches and tags -->
<skip>true</skip>
</gitDescribe>
+ <!-- The git.properties is not really
used, but works around an IntelliJ bug where
Review comment:
Why is it important for this to work in IntelliJ?
##########
File path:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/TestStreamEnvironment.java
##########
@@ -69,13 +74,28 @@ public static void setAsContext(
TestStreamEnvironment env =
new TestStreamEnvironment(
miniCluster, parallelism, jarFiles,
classpaths);
+ randomize(conf);
env.configure(conf, env.getUserClassloader());
return env;
};
initializeContextEnvironment(factory);
}
+ /**
+ * Randomizes configuration on test case level even if mini cluster is
used in a class rule.
+ *
+ * @param conf
+ */
+ private static void randomize(Configuration conf) {
+ if (Randomization) {
+ final String testName = TestNameProvider.getCurrentTestName();
Review comment:
hmm...like, we _could_ add a hook to setAsContext to pass the
name/modify the config/pass a factory, but it'd still suck since the
TestNameProvider must live within the `TestLogger`; we just can't get around
that singleton access can we...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
