wuchong commented on a change in pull request #14530:
URL: https://github.com/apache/flink/pull/14530#discussion_r556528704
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaOptions.java
##########
@@ -698,6 +705,42 @@ private static boolean
hasKafkaClientProperties(Map<String, String> tableOptions
throw new TableException("Unknown value fields strategy:" + strategy);
}
+ public static ReadableConfig
autocompleteSchemaRegistrySubject(ReadableConfig tableOptions) {
+ Configuration configuration = (Configuration) tableOptions;
Review comment:
It's error-prone to do the hard cast here. `ReadableConfig` maybe not
`Configuration`.
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaOptions.java
##########
@@ -253,6 +258,8 @@ private KafkaOptions() {}
// Other keywords.
private static final String PARTITION = "partition";
private static final String OFFSET = "offset";
+ public static final String AVRO_CONFLUENT = "avro-confluent";
+ public static final String DEBEZIUM_AVRO_CONFLUENT =
"debezium-avro-confluent";
Review comment:
Can be `private`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
